fix(libs): Show metadata origin #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
jahow
reviewed
Nov 7, 2023
| metadata.recordUpdated || | ||
| metadata.updateFrequency || | ||
| metadata.status | ||
| " | ||
| [title]="'record.metadata.origin' | translate" | ||
| > | ||
| <p class="mb-5 pt-4 whitespace-pre-line break-words" gnUiLinkify> |
There was a problem hiding this comment.
I think you need to also hide that block if there's no lineage, otherwise it makes a lot of whitespace
jahow
approved these changes
Nov 8, 2023
Angi-Kinas
force-pushed
the
DH-fix-lineage-display
branch
from
1f0589c to
f4a787c
Compare
|
Error on backporting to branch 2.0.x, see Docker Hub actions for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the metadata origin will be displayed if there is data present, even if there is no lineage text: